EmbarkStudios / mirror-mirror

🪞 Powerful reflection library for Rust
Apache License 2.0
79 stars 2 forks source link

Remove num-traits and ordered-float #143

Closed Jasper-Bekkers closed 5 months ago

Jasper-Bekkers commented 5 months ago

Checklist

Description of Changes

This removes ordered-float as a dependency and replaces it with tiny-ordered-float which supports just enough use-cases for this library.

This is mostly done to remove the (very slow to compile) transitive dependency num-traits for this crate so we can keep it lean and mean.

Notice that this doesn't remove num-traits from the Cargo.lock because the optional macaw dependency still wants it, but we don't use that feature so I'll leave removing num-traits there as an exercise for the reader.

davidpdrsn commented 5 months ago

Seems the no-std build of tiny-ordered-float fails. We're removing no-std support for mirror-mirror 0.2 but for 0.1 we need to keep supporting it.

I was gonna file a PR to tiny-ordered-float but the GitHub repo seems to be private, at least https://github.com/Traverse-Research/tiny-ordered-float gives me a 404.

Jasper-Bekkers commented 5 months ago

I was gonna file a PR to tiny-ordered-float but the GitHub repo seems to be private, at least https://github.com/Traverse-Research/tiny-ordered-float gives me a 404.

I've made the repo public now.

Jasper-Bekkers commented 5 months ago

I've released a new version of tiny-ordered-float with no_std support, and I've updated this PR.