Support glam and macaw types

EmbarkStudios / mirror-mirror

🪞 Powerful reflection library for Rust

Apache License 2.0

79 stars 2 forks source link

Support glam and macaw types #85

Closed davidpdrsn closed 1 year ago

davidpdrsn commented 1 year ago

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This adds impls for Reflect and friends for types from glam and macaw, behind a feature flag.

davidpdrsn commented 1 year ago

Can't quite merge this yet. We need some special handling of glam's types that changes depending on architecture (such as Vec4).

davidpdrsn commented 1 year ago

This should be good to go now. I've tested compiling it with and without simd support for glam (using its core-simd feature) and it works. I just decided not to support the types that don't have a stable definition for now.

bnjbvr commented 1 year ago

Hah, auto-merge is fast! I'll open a PR with the suggested changes.