search

EmbarkStudios / octobors

Rust program for automerging PRs based on a few rules
Apache License 2.0
40 stars 2 forks source link

The inactive check is a bit too aggressive #31

Open bnjbvr opened 1 year ago

bnjbvr commented 1 year ago

Describe the bug

If a PR has been inactive, but its mergeable status goes from blocked (because e.g. required checks haven't passed: a conversation hasn't been marked as resolved and the repo owner mandates that conversations be resolved) to unblocked, then the PR is still considered inactive (i.e. its last update time isn't updated). As a matter of fact, the bot won't merge such a pull request, and needs to be manually woken up.

To Reproduce Steps to reproduce the behavior:

  1. In a repo that mandates conversations to be resolved before merging, open a PR
  2. open a conversation in that PR
  3. get a proper review from that PR, so octobors marks it as reviewed (and tries to queue it for merge)
  4. resolve the conversation

Expected behavior The bot should merge the next time it runs (in narrator's voice: it does not, and instead considers the PR to be inactive).

thefuntastic commented 9 months ago

Follow up to see if this is still an issue with the new merge queue

davidpdrsn commented 9 months ago

Technically it's still an issue, we just don't use octobors internally as much. So its not much of an issue for us.