Add maintenance label - Githubissues

EmbarkStudios / octobors

Rust program for automerging PRs based on a few rules

Apache License 2.0

40 stars 2 forks source link

Add maintenance label #40

Open TimonPost opened 1 year ago

TimonPost commented 1 year ago

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Fixes: #39

This adds a maintenance label that if added to PR it will block merging even if all other conditions are med. In addition, octoborus can be configured with a maintenance cron job time that if set will merge all PRs with the maintenance label at the scheduled time.

TimonPost commented 1 year ago

A bit divided if we should add scheduling in octobors or if we may get away by using something like: https://github.com/marketplace/actions/schedule-job-action

TimonPost commented 1 year ago

Can get pretty advanced if we want to do this in octoborus

Iterate all PR with maintainence label.
Check if maintenece time
Merge PR if approved and maintenence time is med.
Rebase PR if a preious PR is med.
Update protocol version
Push changes
Next PR

TimonPost commented 1 year ago

Alright, the simplest first effort I think is to just remove the maintenance label to unblock a merge. Then its up to the dev to take care of rebasing properly.