One of my PRs had received full approval, but the bot wasn't accepting that it was reviewed. While inspecting logs I found that it was reporting the wrong review state:
2023-02-28 15:40:08 | INFO repo{name="xxxx"}:pr{number=8710}: octobors::process: Not yet approved by review
2023-02-28 15:40:08 | INFO repo{name="xxxx"}:pr{number=8710}: octobors::review: review user=repi review=ChangeRequested
Inspecting the list of reviews it reported, I found that the list had only 30 elements, from the start of the PR. Since the latest were missing, I wrote a small code-snippet (see bottom) replicating the merge-check. This code reported 57 reviews and approved. Worth noting is that 30 items is the number of items per page.
This may be related to our usage of ghProxy, as the code here will bypass the proxy for each following link as I can understand it:
Describe the bug
One of my PRs had received full approval, but the bot wasn't accepting that it was reviewed. While inspecting logs I found that it was reporting the wrong review state:
Inspecting the list of reviews it reported, I found that the list had only 30 elements, from the start of the PR. Since the latest were missing, I wrote a small code-snippet (see bottom) replicating the merge-check. This code reported 57 reviews and approved. Worth noting is that 30 items is the number of items per page.
This may be related to our usage of ghProxy, as the code here will bypass the proxy for each following link as I can understand it:
https://github.com/EmbarkStudios/octobors/blob/6b6bbb28479f9ea73cf276ad575c3c39b89a10b6/src/context.rs#L69-L72
To Reproduce
No idea.
Expected behavior
All comments are found by the bot.
Additional context