search

EmbarkStudios / octobors

Rust program for automerging PRs based on a few rules
Apache License 2.0
40 stars 2 forks source link

Bot does not auto merge even though all checks are OK #45

Open Hoodad opened 1 year ago

Hoodad commented 1 year ago

Describe the bug An internal PR had all reviewers approving and CI verified the status of the build as OK. Still the bot refused to merge.

To Reproduce

  1. Assign three reviewers, one from a team, one manually assigned and one code owner
  2. The CI builds and confirms the code is good
  3. Code owner removes self as the reviewer
  4. Both remaining reviewers approved
  5. Bot adds label "reviewed"

This is how the issue occurred. Though I'm not sure how often this happens if this procedure is repeated....

Expected behavior The bot would merge once the reviewers approved

bnjbvr commented 1 year ago

To debug this kind of situation, you could now enable the react_to_comments in your code base, and ask the bot why it's blocked, whenever that happens.