Add label to PR on internal errors

EmbarkStudios / octobors

Rust program for automerging PRs based on a few rules

Apache License 2.0

40 stars 2 forks source link

Add label to PR on internal errors #48

Closed davidpdrsn closed 1 year ago

davidpdrsn commented 1 year ago

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

We've seen some deserialization errors in the logs causing PRs not to get merged. From the outside you can't see that and the bot is just silent.

This makes the bot add an error_label to failed PRs.

davidpdrsn commented 1 year ago

Having thought some more about this I don't think this approach will actually work 😕 Failing to deserialize a PR will cause this to fail https://github.com/EmbarkStudios/octobors/blob/main/src/lib.rs#L143. However if we cannot deserialize the PRs then we cannot post a comment on the PR either because we won't know which PR failed.

So I think I'll just close this for now.