EmbarkStudios / opensource-template

🌻 Template for creating new repositories
https://github.com/EmbarkStudios
Apache License 2.0
89 stars 20 forks source link

Update rusti-ci template #29

Closed Jake-Shadle closed 3 years ago

Jake-Shadle commented 3 years ago
lpil commented 3 years ago

What do you think of any removing the use of the cargo action? It actually recommends using run: cargo test etc unless you're using its extra features, which we're not from what I can see.

It's more concise and means we have one less action to download.

Jake-Shadle commented 3 years ago

That's true, we would miss out on Warnings and errors issued by cargo will be displayed in GitHub UI, but then again, cargo's output is easily readable in the log anyways, that feature is just extra sugar. I'll just remove it.

lpil commented 3 years ago

Oh! That seems like a good though reason to keep it if people find it handy. I didn't realise that.

Jake-Shadle commented 3 years ago

I actually never use it and just go directly to the logs tbh.