EmbarkStudios / opensource

Open source processes, policies, and info
Apache License 2.0
47 stars 3 forks source link

Fix warnings on our crates on lib.rs #43

Open repi opened 2 years ago

repi commented 2 years ago

lib.rs has new support that runs some custom lints to validate crate definitions and metadata, we should go through all of the warnings on our Embark crates and try and fix the warnings and recommendations for our crates, full list here:

https://lib.rs/~embark-studios/dash

celialewis3 commented 2 years ago

Looks like we can close this one, since all tasks are complete?

repi commented 2 years ago

oh awesome that @Jake-Shadle fixed so many already!

the listed tasks are complete but there are a bunch more on the page that should be fixed up: https://lib.rs/~embark-studios/dash

though not all of them are fixable, for example have private repos for some crates (so they are not technically open source, just published on crates.io). but many of the listings in there still think need to be followed up on to close this