search

EmbarkStudios / pdm-plugin-torch

A tool for managing torch-variants with PDM.
Apache License 2.0
32 stars 5 forks source link

feat: Support PyTorch Nightly #20

Open T145 opened 10 months ago

T145 commented 10 months ago

Ex: https://download.pytorch.org/whl/nightly/cu121/

tgolsson commented 10 months ago

Hey!

I'd be happy to support this, and would accept a PR to that effect. Before we get there though, how'd you want to configure it?

T145 commented 10 months ago

Well you already have settings that configure the endpoints, so all you'd need is a way to handle the base URL. Maybe a --nightly arg and enable-nightly config option:

if self.enable_nightly:
            for cuda_version in self.cuda_versions:
                resolves[cuda_version] = (
                    f"https://download.pytorch.org/whl/nightly/{cuda_version}/",
                    f"+{cuda_version}",
                )

It shouldn't be hard to intuit.

tgolsson commented 10 months ago

Ack, just wanted to see if there was a specific problem you wanted to solve (e.g. "I use torch 2.1 but because of bug X my rocm needs to use nightly").