search

EmbarkStudios / physx-rs

🎳 Rust binding for NVIDIA PhysX 🦀
http://embark.rs
Apache License 2.0
658 stars 43 forks source link

Do not manually free materials for shapes #215

Closed tgolsson closed 1 year ago

tgolsson commented 1 year ago

Fixes #180

@rlidwka Correct analysis indeed, Physx internally decrements the ref count so no need for our wrappers to do so -- that leads to decrementing the ref-count twice. Do you have a bigger context where you'd be able to try this and ensure it now works?

rlidwka commented 1 year ago

Do you have a bigger context where you'd be able to try this and ensure it now works?

I've tried it, and I'm pretty sure this solution works.

tgolsson commented 1 year ago

Thanks! Will try to get a release done next week.