search

EmbarkStudios / texture-synthesis

🎨 Example-based texture synthesis written in Rust 🦀
http://embark.rs
Apache License 2.0
1.75k stars 83 forks source link

Enable embark v03 clippy lints #160

Closed celialewis3 closed 3 years ago

celialewis3 commented 3 years ago

Fixed #159 to update clippy lints in lib.rs to Embark's v03 clippy lints.

Jake-Shadle commented 3 years ago

You'll need to add the lints to main.rs as well since this is both a library and a binary.

celialewis3 commented 3 years ago

I added the lints to main.rs as well as copied the full contents from BEGIN to END. However I had to leave out #![deny(unsafe_code)] in lib.rs because we have several unsafe blocks in there.

Jake-Shadle commented 3 years ago

That's fine, the lints are generally applicable, but don't fit for all of our current code.

repi commented 3 years ago

I added the lints to main.rs as well as copied the full contents from BEGIN to END. However I had to leave out #![deny(unsafe_code)] in lib.rs because we have several unsafe blocks in there.

Don't leave it out in the template, do an allow(unsafe_code) after it instead. the template should be unchanged but it is fine to override after it in the crate-specific section. can look a bit silly but it is so that we can just copy'n'paste the template to any repo unmodified