search

EmbeddedEnterprises / ng6-golden-layout

Golden-Layout binding for Angular 6/7/8...
BSD 3-Clause "New" or "Revised" License
60 stars 30 forks source link

Update Angular Dependency #72

Closed mcdenhoed closed 3 years ago

mcdenhoed commented 4 years ago

Angular 11 is now out. I tried migrating an app using ngx-golden-layout and I got the following error:

                  Package "ngx-golden-layout" has an incompatible peer dependency to "@angular/common" (requires "^9.0.0" (extended), would install "11.0.0").
                  Package "ngx-golden-layout" has an incompatible peer dependency to "@angular/core" (requires "^9.0.0" (extended), would install "11.0.0").

Would it be possible to extend/update the angular dependency to allow usage with 11?

martin31821 commented 3 years ago

I'll take a look once I updated our app to ng11.

Can you confirm that the binding works with angular 11?

mcdenhoed commented 3 years ago

Yeah, shortly after I posted this I forced the upgrade and it does seem to work. Been running them together for a few weeks now and haven't had any issues.

martin31821 commented 3 years ago

Thanks for confirming, will update tomorrow.

mCzolko commented 3 years ago

Looking forward to tomorrow :D

martin31821 commented 3 years ago

updated to ng13.

mcdenhoed commented 3 years ago

Thanks! And thanks for all the awesome work on GL proper!