search

Ember-Swiper / ember-cli-swiper

Swiper-Wrapper for ember
https://ember-swiper.github.io/ember-cli-swiper/
MIT License
72 stars 75 forks source link

Add `data-` attributeBindings to swiper-slide components #114

Closed anulman closed 4 years ago

anulman commented 5 years ago

I used all data- attributes mentioned in the Swiper API docs, plus data-id for more manual handling.

Matt-Jensen commented 5 years ago

Looking good, however I can't merge without tests 🙂

anulman commented 5 years ago

Sounds good! Something like the classlist tests in https://github.com/Ember-Swiper/ember-cli-swiper/blob/master/tests/integration/components/swiper-slide-test.js ?

Matt-Jensen commented 5 years ago

Yes please and thank you!

anulman commented 5 years ago

Tests added!