search

EmberSherpa / ember-cli-velocity

EmberCLI Addon wrapper for Velocity.js
MIT License
10 stars 11 forks source link

velocity-animate is not installed with Ember CLI 2.3.0-beta.2 #11

Open zoltan-nz opened 8 years ago

zoltan-nz commented 8 years ago

I just created a new app with Ember CLI 2.3.0-beta.2.

$ ember new test-app

Installed ember-cli-velocity

$ ember install ember-cli-velocity

Try to launch the server

$ ember s

Get this error message:

➜  test-app git:(master) ✗ ember s
version: 2.3.0-beta.2
Cannot find module 'velocity-animate'
Error: Cannot find module 'velocity-animate'
    at Function.Module._resolveFilename (module.js:339:15)
    at Function.require.resolve (internal/module.js:23:19)
    at Class.treeForVendor (/Users/szines/projects/temp/test-app/node_modules/ember-cli-velocity/index.js:14:60)
    at Class._treeFor (/Users/szines/projects/temp/test-app/node_modules/ember-cli/lib/models/addon.js:322:31)
    at Class.treeFor (/Users/szines/projects/temp/test-app/node_modules/ember-cli/lib/models/addon.js:292:19)
    at /Users/szines/projects/temp/test-app/node_modules/ember-cli/lib/broccoli/ember-app.js:439:20
    at Array.map (native)
    at EmberApp.addonTreesFor (/Users/szines/projects/temp/test-app/node_modules/ember-cli/lib/broccoli/ember-app.js:437:30)
    at EmberApp._processedVendorTree (/Users/szines/projects/temp/test-app/node_modules/ember-cli/lib/broccoli/ember-app.js:858:29)
    at EmberApp._processedExternalTree (/Users/szines/projects/temp/test-app/node_modules/ember-cli/lib/broccoli/ember-app.js:888:21)

Solution: manually add velocity-animate package to package.json, but I guess it could be automatically added. Maybe something changed in the CLI api recently?

taras commented 8 years ago

What version of npm are you using?

runspired commented 8 years ago

This is a confirmed bug I haven't had time to fix. I believe we just need to return the result here.

https://github.com/EmberSherpa/ember-cli-velocity/blob/master/blueprints/ember-cli-velocity/index.js#L8

zoltan-nz commented 8 years ago

Latest npm, 3.7.1, node is v5.5.0

Keeo commented 8 years ago

+1

cemarte commented 8 years ago

Hey @runspired, I'm using ember-cli 2.3.0, tried your solution here and it seems to fix the problem. It is also causing a bug in ember-velocity-mixin addon when installing though ember install ember-velocity-mixin.