Emberlynn-Loo / pe

0 stars 0 forks source link

Planned enhancements not specific enough #22

Open Emberlynn-Loo opened 7 months ago

Emberlynn-Loo commented 7 months ago

Expected detailing of how and why you are planning to make this enhancement and what does it affect now

Actual Only lists what you plan to enhance

Screenshot 2024-04-19 at 6.02.03 PM.png

nus-pe-bot commented 7 months ago

Team's Response

We believe that the information provided under Planned Enhancements covers the how and why sufficiently.

The team has also provided some examples to demonstrate what these enhancements look to achieve.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** It would have been a low issue severity if accepted as a bug. It is not purely cosmetic as the developer guide is meant to guide developers through the software. It needs to explain how developers can develop the software product further and therefore not thoroughly explaining the DG of how and why you plan to make this enhancement and what does it affect now would be a minor inconvenience to them. They might be able to see the features to be enhanced but not the reasoning behind them and implement them for the wrong reasons/specifications that it was meant to help with. This would hinder/slow them down. For example, in the 3rd planned enhancement, your team did not specify exactly why it is a problem that the current date validation does not check if the order date is outdated when `addorder` command is called. You could add a sentence that explains this, like `this would cause inconvenience to the user as they would be able to add an invalid order date, which is a bug that is not caught for the user, hindering normal usage of the app.` This would make the planned enhancement clearer. ![Screenshot 2024-04-23 at 5.47.33 PM.png](https://raw.githubusercontent.com/Emberlynn-Loo/pe/main/files/711a17f5-e015-4606-9192-dc9a66d1cdea.png)