Emberlynn-Loo / pe

0 stars 0 forks source link

Invalid phone number works #3

Open Emberlynn-Loo opened 5 months ago

Emberlynn-Loo commented 5 months ago

Steps to reproduce

  1. Input add n/a p/1412323233434 e/aa@gmail a/1234 c/aaa

Expected Error message to be shown

Actual No error message shown

Screenshot 2024-04-19 at 4.21.33 PM.png

nus-pe-script commented 5 months ago

Team's Response

Phone numbers in the world vary in length.

It would be overzealous to reject a phone number of length 13. (PS: The longest valid phone number in the world is 15 digits, not to mention country codes or extensions)

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It is true that phone numbers in the world vary in length, and as you stated, the maximum length is 15 digits. However, this was not specified in the UG. Users would normally expect phone numbers to only go up to about 8 digits. The application can also go above 15 digits as mentioned in issue #5, these constraints are not specified.

Depending on the country, different people's phone numbers would have a different number of digits. Since your team's target profile is restaurant owners, it is reasonable to infer that these restaurants would be managed locally as your app is about making delivery food orders, and small restaurants are highly unlikely to make overseas deliveries. Thus, it is safe to assume that every contact in your app would be from the same country, and thus have the same number of digits in their phone number. Thus, since it is not specified in the UG that your team variable number of digits in your phone number, average users would be confused when they are able to add phone numbers that do not conform to their specific countries' standards. This would confuse them and hinder their usage of their app.

I think a better solution to this problem would be that once a phone number has been added to the app with a specified number of digits, a warning should be given whenever the user tries to add a phone number with a different number of digits. This will allow the user to make the final decision on whether they want to add such a phone number or not, thus clearing the misconception and removing the hindrance to the user.