Emberwalker
commented
8 years ago This looks good to me; the metadata was only required for if Forgelin was being loaded as a mod, which we're stopping doing anyways :+1:
Closed lopcode closed 8 years ago
Emberwalker
commented
8 years ago This looks good to me; the metadata was only required for if Forgelin was being loaded as a mod, which we're stopping doing anyways :+1:
objects,I left other documentation to you for the rest of your cleanup, and only edited things that would be actively wrong.
Also removed the adapter metadata because I couldn't figure out why it was there.
I wrote this adapter for Thump in this commit, and everything works fine with Kotlin RC-1: https://github.com/CarrotCodes/Thump/commit/4ae1d063265a64cc2b3c2eeabf4114a84b1c18e2
Also note that you might not need to shade the Kotlin Reflect library any more - I don't need to for Thump, and removing it halves my built Jar size, but that seems beyond the scope of this change.