search

EmbroidePy / pyembroidery

pyembroidery library for reading and writing a variety of embroidery formats.
MIT License
181 stars 33 forks source link

CSV is not valid. #74

Open tatarize opened 4 years ago

tatarize commented 4 years ago

The CSV is a holdover from Embroidermodder but the changes to columns and extra spaces are not actually valid CSV formatting.

LochanLoch commented 3 years ago

and the numbers have a point not a komma what embroidermodder will have. I made a working csv import but it was a lot of handwork.

tatarize commented 3 years ago

There's problems with the comma separation file and using a comma for the radix point which is regionally used in Dutch and some other internationalizations. I actually think if embroidermodder is spitting out a comma there it's likely a bug and an artifact of the localization. You cannot tell the comma between the elements from the comma within the numbers. This would be really weird with parsing, and you could have a program work if you're Dutch and complete fail if you're English.

Embroidermodder doing that is understandable but quite honestly rather a recipe for disaster.