search

EmbroidePy / pyembroidery

pyembroidery library for reading and writing a variety of embroidery formats.
MIT License
181 stars 33 forks source link

DST header in 1/10th mm. MY second AY. #85

Closed tatarize closed 4 years ago

tatarize commented 4 years ago

inkstitch/inkstitch#591 @lexelby @hwilson10 That bug was fixed a long time back in this version. The units should be 1/10th mm. And dividing by Pixels Per Millimeter (PPMM) gives the units in mm.

-- (Edit, removed proof it should be 1/10th mm)

tatarize commented 4 years ago

Actually that MY thing is a legit bug.

tatarize commented 4 years ago

Ah, nevermind that wrong unit switch actually is in the older version. I just corrected it a good while back. The label error is still in my version though.

tatarize commented 4 years ago

The AY --> MY bug was fixed in pyembroidery 1.4.12

tatarize commented 4 years ago

The units bug was fixed Nov. 2018.

https://github.com/EmbroidePy/pyembroidery/commit/944bc89fc79f9efad2043acf509be1c252c958cf

tatarize commented 4 years ago

The implementation of AY and AX was also done Nov. 2018 but didn't come up in the given report.