EmbySupport / Emby.Docs

Source of Emby Support Documentation
https://emby.media/support/
MIT License
6 stars 3 forks source link

change downloads & sync title to Introduction #23

Open sa2000a opened 1 day ago

sa2000a commented 1 day ago

It does not look right that the group of articles title is the same as the first article title - so changing first document title

image

Also for consistency with links from other articles changed the group name from "Download & Sync" to "Downloads & Sync"

softworkz commented 1 day ago

The doc generation is done via DocFX from Microsoft, which also generates their own help content and they are doing this as well:

image

https://learn.microsoft.com/en-us/windows/windows-app-sdk/api/winrt/microsoft.ui.input.inputnonclientpointersource?view=windows-app-sdk-1.6

sa2000a commented 1 day ago

I am not changing the document names - just the title for the first document

For the group of documents group names - is it not just how it is in toc.yml that sets the name ?

softworkz commented 1 day ago

You wrote

It does not look right that the group of articles title is the same as the first article title

I just wanted to note that this is common practice in MS documentation (but not always).

The PR is find for me, sorry for the confusion.

sa2000a commented 1 day ago

to note that this is common practice in MS documentation

wow - i see it now. Thanks. But you are ok to merge it - so i can then do the blank lines before images update

softworkz commented 1 day ago

wow - i see it now. Thanks. But you are ok to merge it

I let Luke do the merging of content-related changes.

so i can then do the blank lines before images update

That's something I'd merge.

But you don't need to wait. Just create a new branch locally from the commit before and do the other changes in that branch. Then push that other branch to your fork-repo and create a PR as usual.

softworkz commented 1 day ago

Which Git tool do you use? Then I can guide you..

sa2000a commented 1 day ago

Which Git tool do you use? Then I can guide you..

On plex i used "VS2019 Dev Tools command line" but on advice from eric, I now use Github Desktop which makes life a lot easier

Hope i did the temporary branch for the linefeeds PR correctly

softworkz commented 1 day ago

All fine, seems you don't need any guidance ;-)