search

EmchBerger / cube-common-bundle

Common Code for the CUBE Tools
0 stars 2 forks source link

[DataDogAudit] Suggest renaming from "KEY_LEFT" to "KEY_UNCHANGED" #22

Closed MartinRosserEB closed 6 years ago

MartinRosserEB commented 6 years ago

https://github.com/EmchBerger/cube-common-bundle/blob/master/src/DataHandling/Logs/DataDogAudit.php#L26

--> suggest to use constant "KEY_UNCHANGED" instead of KEY_LEFT and suggest to use value "unchanged" for this constant.

SimonHeimberg commented 6 years ago

This is fine.

Hint: normally, the old constant would stay for one version const KEY_LEFT = static::KEY_UNCHANGED