search

EmcraftSystems / linux-emcraft

uClinux for Cortex-M3 and Cortex-M4, version 2.6.33
http://www.emcraft.com
Other
267 stars 209 forks source link

Update drivers/serial/stm32_usart.c #1

Closed crovisa closed 12 years ago

crovisa commented 12 years ago

Added options parsing on stm_console_setup Added code to stm_port_set_termios to allow port settings change from userland using termios

aspotashev commented 12 years ago

Hello Jordi,

Congratulations with the first pull request to our Linux kernel tree!

The stm_port_set_termios() must be very important for many Linux-based applications, we really appreciate your effort. Please find above my comments on the code.

Also, we strictly follow the coding style generally used in Linux kernel. It would be great if you convert your patch to this coding style, so that we can just pull your commit as is into our main repository. See linux/Documentation/CodingStyle for details.

Alexander Potashev, Emcraft Systems

crovisa commented 12 years ago

Will do. I've got another drivers for STM32 like RTC and SPI using DMA. I could share them if you feel they'd be useful El 15/06/2012 22:05, "Alexander Potashev" < reply@reply.github.com> escribió:

Hello Jordi,

Congratulations with the first pull request to our Linux kernel tree!

The stm_port_set_termios() must be very important for many Linux-based applications, we really appreciate your effort. Please find above my comments on the code.

Also, we strictly follow the coding style generally used in Linux kernel. It would be great if you convert your patch to this coding style, so that we can just pull your commit as is into our main repository. See linux/Documentation/CodingStyle for details.

Alexander Potashev, Emcraft Systems

Reply to this email directly or view it on GitHub: https://github.com/EmcraftSystems/linux-emcraft/pull/1#issuecomment-6365358

aspotashev commented 12 years ago

Thanks in advance for fixing the remaining issues in stm_port_set_termios!

We will be happy to include more drivers for STM32 peripherals into our Linux port. It would be very helpful for us if you share the RTC and SPI drivers.

Have a nice weekend!

aspotashev commented 12 years ago

Jordi,

This pull request has been committed into our repository here on Github, with some minor changes. Thanks for your work!