search

Emenda / klocwork-plugin

Jenkins Klocwork Plugin
1 stars 3 forks source link

Add "Executor (cmd/sh/etc.) option" #40

Open andreaslarfors opened 6 years ago

andreaslarfors commented 6 years ago

Currently the plug-in is hard-wired to use cmd in Windows operating systems and sh in Linux operating systems when invoking e.g. kwinject, kwbuildproject etc.

Make this configurable so that a custom executor can be specified.

Source of this request: in some configurations, the character limit of 8192 for cmd.exe is being exceeded (long paths + lists of files).

michael-baron commented 6 years ago

Hi Andreas,

Agree this could be done. One thought at an alternative solution would be to change our kw commands to use arguments lists if they are too long. I assume the main source of the issue is with things like the kwciagent call were we are passing the list of all the changed files to the cmd. We could change this to be something like kwciagent run @diff_file_list to resolve the length issue.

What do you think?

andreaslarfors commented 6 years ago

Hi Michael,

Yes, that's another solution to this particular problem, and probably a more "correct" one. However I think it might be useful to allow users to specify their executor regardless.

I've already completed the work for this, I just need to merge it into the repo.

Andreas