EmeraldSnorlax / manjarno

Why you shouldn't use Manjaro
https://manjarno.snorlax.sh/
BSD 3-Clause "New" or "Revised" License
130 stars 13 forks source link

Add Firefox GNOME Theme section #27

Closed TheEvilSkeleton closed 1 year ago

TheEvilSkeleton commented 1 year ago

Closes https://github.com/EmeraldSnorlax/manjarno/issues/26

EmeraldSnorlax commented 1 year ago

i dont know how to feel about this as, well, "small" bugs do happen and they do result in acessibility regressions. this does indeed go against the upstream maintainers explicit wishes though, so im not sure where this fits in. personally, this feels more of a misc. issue but im very much open to hearing other people's considerations

EmeraldSnorlax commented 1 year ago

https://stopthemingmy.app/ this might also be apt to mention

TheEvilSkeleton commented 1 year ago

Misc works for me, but I'd say stability makes sense as well, since Firefox was practically unusable (and thus a stability issue in many ways). And yes, I agree that Please don’t theme our apps should be mentioned too.

I'll move it to Misc.

EmeraldSnorlax commented 1 year ago

actually, what do you think of breaking this out into its own heading? manjaro ignoring upstream devs seems to be a repeated trend (e.g. asahi)

TheEvilSkeleton commented 1 year ago

actually, what do you think of breaking this out into its own heading? manjaro ignoring upstream devs seems to be a repeated trend (e.g. asshi)

I like that. We could use Firefox GNOME Theme as an example, as well as https://dont-ship.it and https://stopthemingmy.app. Besides, they ship a custom GTK theme (and icon theme). I can provide examples along the way.

rafaelmardojai commented 1 year ago

Hello, I know you have good intentions here, but I would like to avoid too much drama about this. I hope I can arrive to a constructive discussion with Manjaro, so future users get the best outcome. (rafaelmardojai/firefox-gnome-theme#528)

Thanks.

EmeraldSnorlax commented 1 year ago

i also agree, and i'm glad to see that things are moving in the right direction in terms of discussion -- hopefully the goal for this article is to silently become obsolete as manjaro gets better at running things (even though this started off with not the greatest intentions from edgy me a few years ago, lol)

i'd also want to get @Chrysostomus's side of things here too; from reading the thread it looks like this is a historical issue that did not fully have the fix propagated to users, in which case this wouldn't be as severe of a misstep and i'd once again be a little reluctant to add here (at least, not without heavy context)

rafaelmardojai commented 1 year ago

i also agree, and i'm glad to see that things are moving in the right direction in terms of discussion -- hopefully the goal for this article is to silently become obsolete as manjaro gets better at running things (even though this started off with not the greatest intentions from edgy me a few years ago, lol)

i'd also want to get @Chrysostomus's side of things here too; from reading the thread it looks like this is a historical issue that did not fully have the fix propagated to users, in which case this wouldn't be as severe of a misstep and i'd once again be a little reluctant to add here (at least, not without heavy context)

As far as I know, previously the theme was always applied to users. Now they add it behind a toggle on their greeter application, but the toggle is enabled by default, so is fair to think that many user didn't gave it enough attention.

EmeraldSnorlax commented 1 year ago

in that case, i think that still shows them not listening to upstream devs?

Chrysostomus commented 1 year ago

I had not noticed the disclaimer in the repo about not shipping it before, but it was brought to my attention recently. Based on the request, it is no longer enabled by default in the next release, and the greeter app will have more information about the theme in the toggle.

rafaelmardojai commented 1 year ago

in that case, i think that still shows them not listening to upstream devs?

I'm not sure about that. This is the first time I openly talked about my will of they stoping doing that.

EmeraldSnorlax commented 1 year ago

ah, once again that is my mistake and didnt realise this was the first time. i don't really see the point of including this pr then, as "small" bugs are out of scope here. feel free to comment with further discussion if wanted