search

EmergeTools / Pow

Delightful SwiftUI effects for your app
https://movingparts.io/pow
MIT License
3.64k stars 153 forks source link

Crash in `SmokeEffect` #37

Closed SwiftyAlex closed 11 months ago

SwiftyAlex commented 11 months ago

SmokeEffect references a couple particle images which aren't there, causing a forced crash with an unwrap.

The assets for the package only contains "anvil_smoke_gray" and "anvil_smoke_white", but the effect references the below:

    let particles = [
        "anvil_smoke_gray",
        "anvil_smoke_gray_blur",
        "anvil_smoke_gray_alt",
    ]
Assets
Screenshot 2023-11-29 at 16 25 07
robb commented 11 months ago

Good catch, we're looking into it.

mergesort commented 11 months ago

@SwiftyAlex I have a fix ready but am waiting on a fix to a permissions issue that's preventing me from pushing code to the main branch. When that's settled the smoke effect will work again, in the mean time I appreciate your patience! 🙇🏻‍♂️

SwiftyAlex commented 11 months ago

Oooh fantastic, thanks both

I would have loved to help myself but could only guess what they were supposed to look like - can hopefully return the favour one day! 😄

mergesort commented 11 months ago

@SwiftyAlex This should now be fixed in 1.0.1, would love to confirm that it's fixed for you!

SwiftyAlex commented 11 months ago

lookin' real smokey 💨

https://github.com/EmergeTools/Pow/assets/13989549/8769c8d1-b0bd-46c4-ad8f-a1b613888006

thanks again!