EmergeTools / hackernews

A simple Hackernews client for Android. iOS coming soon.
https://www.emergetools.com/blog/posts/open-sourcing-emerge-tools-hackernews-app
MIT License
59 stars 6 forks source link

Bookmarking Stories to Read Later #74

Closed Rahkeen closed 2 months ago

Rahkeen commented 2 months ago

With this diff, I'm taking a pass at bookmarking functionality. This required adding some infrastructure, namely Room as our local database.

The action is wired up to a long press for now, which will allow you to bookmark / unbookmark a story. There is also a separate screen and bottom nav item for bookmarks so we can easily navigate there.

emerge-tools[bot] commented 2 months ago

2 builds increased size

Name Version Download Change Install Change Approval
:warning: Hacker News
com.emergetools.hackernews
1.0 (1) 1.6 MB ⬆️ 48.6 kB (3.22%) 3.4 MB ⬆️ 110.4 kB (3.38%) N/A
:warning: Hacker News
com.emergetools.hackernews.debug
1.0 (1) 9.6 MB ⬆️ 191.3 kB (2.04%) 28.0 MB ⬆️ 504.4 kB (1.84%) N/A

Hacker News 1.0 (1)
com.emergetools.hackernews

⚖️ Compare build ⏱️ Analyze build performance

Total install size change: ⬆️ 110.4 kB (3.38%) Total download size change: ⬆️ 48.6 kB (3.22%)

Largest size changes

Item Install Size Change Download Size Change
📝 androidx.room.RoomOpenHelper ⬆️ 4.3 kB ⬆️ 1.9 kB
androidx.tracing.Trace ⬇️ -3.8 kB ⬇️ -1.7 kB
📝 kotlin.collections.builders.MapBuilder ⬆️ 3.6 kB ⬆️ 1.7 kB
kotlin.text.CharsKt ⬆️ 3.4 kB ⬆️ 1.5 kB
📝 androidx.compose.material3.NavigationBarKt ⬆️ 3.4 kB ⬆️ 1.5 kB
View Treemap [![Image of diff](https://diff-treemap-images.s3.us-west-1.amazonaws.com/emerge-demo/20e05266-551a-4332-bbde-cfb29a07301f.2cbb4579-cce4-4ee6-801e-831340463951.png)](https://www.emergetools.com/compare?head=2cbb4579-cce4-4ee6-801e-831340463951&base=20e05266-551a-4332-bbde-cfb29a07301f&sizeOpen=true&utm_source=github&utm_medium=vcs)

Hacker News 1.0 (1)
com.emergetools.hackernews.debug

⚖️ Compare build ⏱️ Analyze build performance

Total install size change: ⬆️ 504.4 kB (1.84%) Total download size change: ⬆️ 191.3 kB (2.04%)

Largest size changes

Item Install Size Change Download Size Change
📝 androidx.room.InvalidationTracker ⬆️ 5.8 kB ⬆️ 2.0 kB
📝 androidx.room.RoomDatabase ⬆️ 5.2 kB ⬆️ 1.8 kB
📝 androidx.room.util.TableInfoKt ⬆️ 4.8 kB ⬆️ 1.7 kB
📝 androidx.room.RoomDatabase$Builder ⬆️ 4.3 kB ⬆️ 1.5 kB
📝 androidx.room.QueryInterceptorDatabase ⬆️ 4.1 kB ⬆️ 1.4 kB
View Treemap [![Image of diff](https://diff-treemap-images.s3.us-west-1.amazonaws.com/emerge-demo/d7f19b24-1d75-4097-a34b-2fcbeb6ca87e.2d79e020-85bb-4a44-835f-c40cfb7c3616.png)](https://www.emergetools.com/compare?head=2d79e020-85bb-4a44-835f-c40cfb7c3616&base=d7f19b24-1d75-4097-a34b-2fcbeb6ca87e&sizeOpen=true&utm_source=github&utm_medium=vcs)

:flying_saucer: Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

emerge-tools[bot] commented 2 months ago

📸 Snapshot Test

3 modified, 2 added, 8 unchanged

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0 (1) 2 0 3 8 0 ✅ Approved

:flying_saucer: Powered by Emerge Tools

emerge-tools[bot] commented 2 months ago

⏱ Performance Analysis

Hacker News

Head build: Hacker News 1.0 (1) Base build: Hacker News 1.0 (1)

Name Change Comparison
⚠️ Startup (com.emerge.universaltests.EmergeUniversalStartupTest) ⬆️ 12.66% 🛸 View

:flying_saucer: Powered by Emerge Tools