EmergeTools / hackernews

A simple Hackernews client for Android. iOS coming soon.
https://www.emergetools.com/blog/posts/open-sourcing-emerge-tools-hackernews-app
MIT License
59 stars 6 forks source link

A new comment loading approach #89

Closed Rahkeen closed 1 month ago

Rahkeen commented 1 month ago

Previously we were loading the comment tree by using the search api. This was nice but there are a few drawbacks:

Since we were already scraping the comments page for upvote links for each comment, I figured we could try just using the comments page as our data source for comments. The results were fairly good, a simplified model of comments, and immediate updated when we post a top-level comment.

This does get rid of the parent-child relationship between comments, which probably should be revisited, especially when it comes to hiding comment sub-trees. However, this makes the rest of the experience much better.