EmergeTools / hackernews

A simple Hackernews client for Android. iOS coming soon.
https://www.emergetools.com/blog/posts/open-sourcing-emerge-tools-hackernews-app
MIT License
75 stars 10 forks source link

Simple Feed Error Handling #90

Closed Rahkeen closed 3 months ago

Rahkeen commented 3 months ago

In order to make sure that app doesn't just crash constantly, we need to have some basic error handling in place.

The goal of this diff is to have a very simple solution for most cases. For the feed, we can show an error item that allows you to try request the feed again.

I'd love to have a bit more sophistication here, but this is a good first step. At the very least if they lose internet connection the app won't crash.

emerge-tools[bot] commented 3 months ago

📸 Snapshot Test

Error generating snapshot comparison

Name Version Added Removed Modified Unchanged Errored Approval
Hacker News
com.emergetools.hackernews.debug
1.0 (1) 2 0 2 27 0 ⏳ Needs approval
Name Version Error message
Hacker News
com.emergetools.hackernews
1.0 (1) Snapshot extraction timed out

:flying_saucer: Powered by Emerge Tools