Closed akc2267 closed 2 years ago
this looks like the unverified denoms bug again. The values flash for a split second and then disappear https://allinbits.slack.com/archives/C02JXQVAP3K/p1645196882603939?thread_ts=1645194653.266429&cid=C02JXQVAP3K
Isolated all the denoms that the app has tried to verify in the last 24h%5Cn)%20%22%7D%5D)
By automating the call of the API
declare -a arr=(
'12da42304ee1ce96071f712aa4d58186ad11c3165c0dcda71e017a54f3935e66'
'14f9bc3e44b8a9c1be1fb08980fab87034c9905ef17cf2f5008fc085218811cc'
'1d5826f7ede6e3b13009fef994dc9caaf15cc24ca7a9ff436ffb2e56fd72f54f'
'1fbdd58d438b4d04d26cbfb2e722c18984a0f1a52468c4f42f37d102f3d3f399'
'2181aab0218eac24bc9f86bd1364fbbfa3e6e3fcc25e88e3e68c15dc6e752d86'
'42e47a5ba708ebe6e0c227006254f2784e209f4dbd3c6bb77edc4b29ef875e8e'
'5bb694d466ccf099ef73f165f88472af51d9c4991eaa42bd1168c5304712cc0d'
'68a333688e5b07451f95555f8fe510e43ef9d3d44df0909964f92081ef9be5a7'
'81d08bc39fb520ebd948cf017910dd69702d34bf5ac160f76d3b5cfc444ebce0'
'adbec1a7ac2fef73e06b066a1c94dab6c27924ef7ea3f5a43378150009620284'
'b2b5aee174062fa7804ac95223d8169852f8f58962c51c66391c272c838258b7'
'c932adfe2b4216397a4f17458b6e4468499b86c3bc8116180f85d799d6f5cc1b'
'dcd1849e20837bc8fb2c252a7ae1d8aa7a1876911ee669e6ce6fdf9fea54083d'
'e070ce91cc4bd15aec9b5788c0826755aad35052a3037e9ac62be70b4c9a7dbb'
'f7aa8487a9face44a46ac1cd9a668ea10f9f16389f8591555c674fcd8cf70d5f'
)
for i in "${arr[@]}"
do
curl -ks "https://staging.demeris.io/v1/chain/cosmos-hub/denom/verify_trace/${i}" | jq -jr '.verify_trace.ibc_denom, " ", .verify_trace.verified, " ", .verify_trace.trace[].channel, " ", .verify_trace.trace[].counterparty_name, "\n"'
done
we get back the following list of Cosmos denoms and their API results
ibc/12da42304ee1ce96071f712aa4d58186ad11c3165c0dcda71e017a54f3935e66 false
ibc/14f9bc3e44b8a9c1be1fb08980fab87034c9905ef17cf2f5008fc085218811cc true channel-141 osmosis
ibc/1d5826f7ede6e3b13009fef994dc9caaf15cc24ca7a9ff436ffb2e56fd72f54f true channel-217 likecoin
ibc/1fbdd58d438b4d04d26cbfb2e722c18984a0f1a52468c4f42f37d102f3d3f399 false channel-185 regen
ibc/2181aab0218eac24bc9f86bd1364fbbfa3e6e3fcc25e88e3e68c15dc6e752d86 true channel-184 akash
ibc/42e47a5ba708ebe6e0c227006254f2784e209f4dbd3c6bb77edc4b29ef875e8e true channel-186 sentinel
ibc/5bb694d466ccf099ef73f165f88472af51d9c4991eaa42bd1168c5304712cc0d true channel-141 osmosis
ibc/68a333688e5b07451f95555f8fe510e43ef9d3d44df0909964f92081ef9be5a7 true channel-158 starname
ibc/81d08bc39fb520ebd948cf017910dd69702d34bf5ac160f76d3b5cfc444ebce0 true channel-190 persistence
ibc/adbec1a7ac2fef73e06b066a1c94dab6c27924ef7ea3f5a43378150009620284 true channel-232 bitcanna
ibc/b2b5aee174062fa7804ac95223d8169852f8f58962c51c66391c272c838258b7 true channel-204 ixo
ibc/c932adfe2b4216397a4f17458b6e4468499b86c3bc8116180f85d799d6f5cc1b true channel-187 crypto-org
ibc/dcd1849e20837bc8fb2c252a7ae1d8aa7a1876911ee669e6ce6fdf9fea54083d false channel-192 sifchain
ibc/e070ce91cc4bd15aec9b5788c0826755aad35052a3037e9ac62be70b4c9a7dbb true channel-202 emoney
ibc/f7aa8487a9face44a46ac1cd9a668ea10f9f16389f8591555c674fcd8cf70d5f false channel-116 akash
Sifchain and Regen seem to return false erroneously. Akash is due to another issue, not relevant here.
I exported all the relevant Staging tables used during the execution of the method.
cdb_ixo_clients.csv cdb_ixo_connections.csv cdb_cosmos_connections.csv cdb_cosmos_clients.csv cdb_cosmos_channels.csv
cdb_regen_connections.csv cdb_regen_channels.csv cdb_regen_clients.csv cdb_cosmos_denom_traces.csv.csv cdb_sifchain_clients.csv cdb_sifchain_channels.csv cdb_sifchain_connections.csv cdb_ixo_channels.csv
@SpideyPool192
You are already working on unit testing this method
Plz use the exported data in a test harness (e.g. IMPORT
) and call the method with the IXO, Regen and Sifchain traces.
IXO succeeds (correctly) Regen and Sifchain fail (incorrectly) -> Why?
You can get the chains' CNS data for import by calling https://staging.demeris.io/v1/chain/XXX
In case of sifchain, the sifchain's CNS data says the denom is rowan, while we are looking for 'xrowan'. This has to be updated. And regen is not yet enabled on staging, so it says verified false. https://github.com/allinbits/demeris-backend/issues/453 @akc2267
Created #511 to cover the edge case of Akash. Created #512 to address the Iris missing traces.
@akc2267 the 4 cases of this ticket (Iris, Regen, Rowan, Akash) have been addressed. Moving to PR, kindly verify and close
Created #511 to cover the edge case of Akash. Created #512 to address the Iris missing traces. @sgerogia These are merged now. Are we good to close this issue?
Is this tracelistener missing some rows? The old demo account has AKT and XPRT on cosmos-hub but this isn't reflected on Emeris