[API-Server] Add Sentry instrumentation to db calls

EmerisHQ / demeris-backend

Monorepo containing all the Demeris backend code and infrastructure definitions.

GNU Affero General Public License v3.0

8 stars 1 forks source link

[API-Server] Add Sentry instrumentation to db calls #721

Closed Pitasi closed 2 years ago

Pitasi commented 2 years ago

With this PR (https://github.com/EmerisHQ/demeris-api-server/pull/119) we introduced sentry support. We can start tracking spans for each of our database calls.

DoD:

[x] have a sub-span for each query against the database, use the SQL stmt as the span name

tbruyelle commented 2 years ago

use the SQL stmt as the span name

@Pitasi You mean the whole SQL query ? In price-oracle we used the go method name.

Pitasi commented 2 years ago

@tbruyelle I think either is fine, whatever is easier :)

tbruyelle commented 2 years ago

@tbruyelle I think either is fine, whatever is easier :)

On my side I think using the SQL is not handy because it can be very long and it can more difficult to find it in the code rather than a method name. So I go for method names.