search

EmerisHQ / demeris-backend

Monorepo containing all the Demeris backend code and infrastructure definitions.
GNU Affero General Public License v3.0
8 stars 1 forks source link

feat: upgrade Tracelistener to v1.6.0 in dev #751

Closed Pitasi closed 2 years ago

Pitasi commented 2 years ago

This release enables (behind a feature flag) the new sqlgen tool. The new queries don't overwrite fresh data with older data while the nodes are syncing!

I did some tests in dev before opening this PR.

DeshErBojhaa commented 2 years ago

non related q, why only true values are quoted? Non bool and non numbers should be "" to avoid spacial chars. And bools and numbers can be un-quoted. Seems like we're doing the opposite. 🤔 💭

Pitasi commented 2 years ago

@DeshErBojhaa first of all I admit just copy pasted so 😛

since it's an env variable we want it to be a string, so we want "true" string not true bool

maybe k8s is smart enough to convert it from bool to string anyway but who knows

Pitasi commented 2 years ago

@DeshErBojhaa first of all I admit just copy pasted so 😛

since it's an env variable we want it to be a string, so we want "true" string not true bool

maybe k8s is smart enough to convert it from bool to string anyway but who knows