EmerisHQ / demeris-backend

Monorepo containing all the Demeris backend code and infrastructure definitions.
GNU Affero General Public License v3.0
8 stars 1 forks source link

Change our github action to tag even without minor/patch labels #753

Closed Pitasi closed 2 years ago

Pitasi commented 2 years ago

Repos involved:

Current state:

Desired state:

akhilkumarpilli commented 2 years ago

This will create tag for every PR then. Creating version for every PR is not a good idea I guess. And we will have a specific version even when a PR have small changes.

Pitasi commented 2 years ago

Yes it will create a tag for every PR (maybe we can have a label to not create any tag?). I don't see any problem in that.

The majority of PRs I have seen needed a tag to deploy api-server. It happened to me to forget this label and had to tag the repo manually.

I understand you are saying we are tagging each commit, so why don't we use commit hashes directly? That's a good question, maybe we can discuss this: do we prefer using semver for readability or return back to the commit hash?

akhilkumarpilli commented 2 years ago

Understood. We can prefer semver instead of commit hash