Closed Pitasi closed 2 years ago
This will create tag for every PR then. Creating version for every PR is not a good idea I guess. And we will have a specific version even when a PR have small changes.
Yes it will create a tag for every PR (maybe we can have a label to not create any tag?). I don't see any problem in that.
The majority of PRs I have seen needed a tag to deploy api-server. It happened to me to forget this label and had to tag the repo manually.
I understand you are saying we are tagging each commit, so why don't we use commit hashes directly? That's a good question, maybe we can discuss this: do we prefer using semver for readability or return back to the commit hash?
Understood. We can prefer semver instead of commit hash
Repos involved:
Current state:
patch
,minor
, or - don't! -major
)Desired state:
patch
number is increased