Cleanup UseSQLGen feature flag in tracelistener - Githubissues

EmerisHQ / demeris-backend

Monorepo containing all the Demeris backend code and infrastructure definitions.

GNU Affero General Public License v3.0

8 stars 1 forks source link

Cleanup UseSQLGen feature flag in tracelistener #765

Open Pitasi opened 2 years ago

Pitasi commented 2 years ago

We established that sqlgen works for tracelistener. We can clean up the env variable and the deprecated code.

DoD

remove the global flag: https://github.com/EmerisHQ/tracelistener/blob/2e0abb8c597cb392f635aca09e90cbd537b4a120/tracelistener/processor/processor.go#L18
remove flag from config https://github.com/EmerisHQ/tracelistener/blob/2a8bed11a512a52039bc6bf1a157672fdcedb03a/tracelistener/config/config.go#L19
cleanup all the "if"s: https://github.com/EmerisHQ/tracelistener/blob/dfa92b003fcf068ce340a32ddb4f3428b5c0a858/tracelistener/processor/validators.go#L28-L37
move the addValAddressColumn migration in the validators.go file where it's used (replace validatorsTableOld with validatorsTable)
delete deprecated database.go file