EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
11 stars 2 forks source link

Need extra 'connect wallet' in tx centre(edge case) #1391

Open fl-y opened 2 years ago

fl-y commented 2 years ago

Describe the bug Try again does nothing when specific circumstances are met

To Reproduce Steps to reproduce the behavior:

  1. Go to https://app.emeris.com/
  2. Without connecting a wallet try swapping until the 'Connect wallet' button pops up
  3. Instead of connecting, close the swap interface so that the tx is inside the tx centre
  4. Open the tx centre and try to sign and click on try again to no avail.

Expected behavior A 'Connect Wallet' modal to display in such a scenario.

Screenshots https://user-images.githubusercontent.com/31615341/159354009-eab2de19-f1c7-447e-b809-15767b20b812.mov

Additional context Add any other context about the problem here. (OS/Browser/Any other information) A new issue pops up when trying to swap CRO. Try with ATOM

peterlewispeterlewis commented 2 years ago

@josietyleung this belongs in frontend (bug fix), correct?

josietyleung commented 2 years ago

@josietyleung this belongs in frontend (bug fix), correct?

yes apologies must be my fat fingers clicking the wrong column

peterlewispeterlewis commented 2 years ago

@josietyleung Is this in the wrong repo or the wrong column?

josietyleung commented 2 years ago

Hey @peterlewispeterlewis this is the frontend repo and I have moved it into the 'must for spring launch' column within the frontend workspace. I think you'll have to move yours on the Design workspace too. Because me moving the issue in the frontend workspace (from design required to must for spring launch in this instance), won't change anything in the design workspace. And the issue will still stay in the 'design intake' for you. image