EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
12 stars 2 forks source link

fix: red dot z index #1709

Closed pranaybaldev closed 2 years ago

pranaybaldev commented 2 years ago

Description

red dot z index as in issue

Fixes: #1705

Testing

  1. Check places where the CircleSymbol component is used and the red dot is at the right level.

Additional Details

How I approached the prob.. turned displaystatus on everywhere by (line-7)..

Screenshot 2022-04-28 at 8 42 24 PM

and got

Screenshot 2022-04-28 at 8 44 22 PM Screenshot 2022-04-28 at 7 41 59 PM

Moving the circlesymbolstatus component down to prevent. Havent tested it extensively.

Screenshot 2022-04-28 at 8 41 34 PM
github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 2964f20):

https://emeris-app--pr1709-fix-1705-red-dot-76gwgrqx.web.app

(expires Tue, 10 May 2022 07:36:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

faboweb commented 2 years ago

Moving the circlesymbolstatus component down to prevent. Havent tested it extensively.

I think the dot should stay on top of the icon. Have you tried setting a higher z-index for overlays?

luciorubeens commented 2 years ago

Moving the circlesymbolstatus component down to prevent. Havent tested it extensively.

I think the dot should stay on top of the icon. Have you tried setting a higher z-index for overlays?

I agree, maybe z-[11] is enough to make it work (since max used is 10 in symbol component).

pranaybaldev commented 2 years ago

Moving the circlesymbolstatus component down to prevent. Havent tested it extensively.

I think the dot should stay on top of the icon. Have you tried setting a higher z-index for overlays?

The dot stays on top of the icon.

pranaybaldev commented 2 years ago

@luciorubeens @fl-y Great suggestion. Unfortunately, 10 is the sweet spot. With 11 or more, the problem remains as in the screenshots above.