EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
12 stars 2 forks source link

fix: ability to select denoms from other chains #1714

Closed luciorubeens closed 2 years ago

luciorubeens commented 2 years ago

Description

Fixes: #1697 #1706

Feature flags

VITE_FEATURE_SWAP_WIDGET_DISABLED=false

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 33654ab):

https://emeris-app--pr1714-fix-dexagg-any-chain-cde3tpw6.web.app

(expires Fri, 06 May 2022 02:40:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

fl-y commented 2 years ago
Screenshot 2022-04-29 at 4 13 11 PM

Appears to be missing the 0.01 on Akash for the demo account

fl-y commented 2 years ago

Regarding #1697 I couldn't find any 0 values across 3 different testing accounts. Apart from the 0.01 on Akash for the demo account LGTM.

Regarding #1706 While swapping ATOM on XPRT to IRIS,

Screenshot 2022-04-29 at 4 40 22 PM

though I imagine this is because the latest fix for negative amounts aren't applied yet. But it was selectable so I think it works 👍

josietyleung commented 2 years ago

All my assets are showing up 💯 now 😊