fix: Allow filter by both ticker and display name

EmerisHQ / demeris

Emeris web app

https://app.emeris.com/

Apache License 2.0

12 stars 2 forks source link

fix: Allow filter by both ticker and display name #1723

Closed clockworkgr closed 2 years ago

clockworkgr commented 2 years ago

Description

Fixes: https://github.com/EmerisHQ/demeris/issues/1718

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 0f40f86):

https://emeris-app--pr1723-fix-filter-both-tick-yp3568en.web.app

_{(expires Fri, 06 May 2022 10:00:20 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

fl-y commented 2 years ago

Does the job feature-wise, however match highlighting seems broken. Not sure whether that should be addressed in a separate issue or here though.

clockworkgr commented 2 years ago

Does the job feature-wise, however match highlighting seems broken. Not sure whether that should be addressed in a separate issue or here though.

it was slightly broken before because it highlighted individual letter rather than substrings.

as for highlighting the ticker name, that is actually displayed via an AmountDisplay component and I'm not sure whether it's worth refactoring to accept a keyword/highlight prop as well...

@eitjuh ?