fix: lodash fix for 1726

eitjuh commented 2 years ago

Quick experiment for lodash fix for https://github.com/EmerisHQ/demeris/pull/1734

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit dc73b4f):

https://emeris-app--pr1737-fix-1726-long-string-tbrk31ee.web.app

_{(expires Sun, 08 May 2022 19:12:54 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

faboweb commented 2 years ago

depends on how good the tree shaking it. need to run an analysis. but yeah maybe our selective import is overkill

Joon @.***> schrieb am Mo. 2. Mai 2022 um 18:41:

@.**** commented on this pull request.

In src/utils/basic.ts https://github.com/EmerisHQ/demeris/pull/1737#discussion_r862748429:

@@ -5,7 +5,7 @@ import { EmerisAPI } from @.***/types'; import { bech32 } from 'bech32'; import BigNumber from 'bignumber.js'; import findIndex from 'lodash/findIndex'; -import isString from 'lodash/isstring'; +import isString from 'lodash/isString';

lol in that case all the lodash.{method} packages & imports were pretty much useless since the entire module is already imported?

— Reply to this email directly, view it on GitHub https://github.com/EmerisHQ/demeris/pull/1737#discussion_r862748429, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMY5WIISZQ6YSX4F64MSN3VH6WNJANCNFSM5U2I3XSQ . You are receiving this because your review was requested.Message ID: @.***>

-- Greets Fabo

fl-y commented 2 years ago

Fixed by using typeof instead https://github.com/EmerisHQ/demeris/pull/1734#discussion_r863552439

EmerisHQ / demeris

fix: lodash fix for 1726 #1737

@.**** commented on this pull request.