EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
12 stars 2 forks source link

Feat/settings slippage error #1744

Closed pranaybaldev closed 2 years ago

pranaybaldev commented 2 years ago

Description

Adds error dialog on invalid slippage vals.

https://www.figma.com/file/04OF6ZbTo0gLzmFm3kLRkS/Emeris-%7C-UI-%7C-Web-App?node-id=14107%3A171563

Fixes: # (issue)

Feature flags

NA

Testing

  1. Go to slippage settings. (Three dots top right on swap component)
  2. Input invalid slippage in 'Custom'. Enable 'allow custom slippage' if not enabled.

Reviews

@luciorubeens

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 91aacd9):

https://emeris-app--pr1744-feat-settings-slippa-wxdp67bq.web.app

(expires Thu, 12 May 2022 10:09:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

luciorubeens commented 2 years ago

Somehow i can't enable the custom slippage option, neither in preview link nor locally, but i don't think it's related to your PR:

CleanShot 2022-05-03 at 15 50 34

Can others review?

Dawntraoz commented 2 years ago

Somehow i can't enable the custom slippage option, neither in preview link nor locally, but i don't think it's related to your PR:

CleanShot 2022-05-03 at 15 50 34

Can others review?

For me is not working neither in production @luciorubeens

pranaybaldev commented 2 years ago

should work now