EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
12 stars 2 forks source link

fix: no truncate amount #1752

Closed pranaybaldev closed 2 years ago

pranaybaldev commented 2 years ago

Description

Fixes 1749. Amounts were being truncated so 0.xyz was shown as 0.

Fixes: #1749

Feature flags

NA

Testing

  1. Go to send/move.
  2. On amount stage, check for 1749 and the bug in ss.

Additional Details

Found another bug. On deleting/backspacing till 0, last shown amount is not 0. Check screenshot.

Screenshots

19.94 should be 0

Screenshot 2022-05-05 at 6 59 22 PM
github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 0e35937):

https://emeris-app--pr1752-fix-1749-send-move-i-ztf67jjz.web.app

(expires Mon, 16 May 2022 05:45:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

fl-y commented 2 years ago

Found another bug. On deleting/backspacing till 0, last shown amount is not 0. Check screenshot.

@pranaybaldev To clarify, this is fixed via this PR or have you reproduced it with this PR as well? (I couldn't reproduce it with this PR's build

pranaybaldev commented 2 years ago

Found another bug. On deleting/backspacing till 0, last shown amount is not 0. Check screenshot.

@pranaybaldev To clarify, this is fixed via this PR or have you reproduced it with this PR as well? (I couldn't reproduce it with this PR's build

@fl-y Fixed it in this PR itself :)