EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
12 stars 2 forks source link

fix/price-amount-not-big-number-fix-ordering #1755

Closed eitjuh closed 2 years ago

eitjuh commented 2 years ago

@Dawntraoz This fixes the ordering for bignumbers like sifchain... it's a bit ugly but it works

It's inspired by orderBalancesByPrice in useAccount.ts, which was not convenient and easy to re-use.

Please refactor how you'd like, I at least wanted to give a hint in the right direction since it was tricky to reproduce

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 13f9051):

https://emeris-app--pr1755-fix-price-amount-not-79l9b9jo.web.app

(expires Mon, 23 May 2022 08:21:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

fl-y commented 2 years ago

since it was tricky to reproduce

@eitjuh Any pointers? I'm afraid I have no idea what the issue is and what I'm supposed to test

eitjuh commented 2 years ago

since it was tricky to reproduce

@eitjuh Any pointers? I'm afraid I have no idea what the issue is and what I'm supposed to test

Sorry @fl-y - this PR was directly targeted at @Dawntraoz . Because it was a bit messy I didn't want to directly commit in her PR. It's not to be merged to prod

eitjuh commented 2 years ago
image

Sorry 🥺