Closed eitjuh closed 2 years ago
Visit the preview URL for this PR (updated for commit 13f9051):
https://emeris-app--pr1755-fix-price-amount-not-79l9b9jo.web.app
(expires Mon, 23 May 2022 08:21:07 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
since it was tricky to reproduce
@eitjuh Any pointers? I'm afraid I have no idea what the issue is and what I'm supposed to test
since it was tricky to reproduce
@eitjuh Any pointers? I'm afraid I have no idea what the issue is and what I'm supposed to test
Sorry @fl-y - this PR was directly targeted at @Dawntraoz . Because it was a bit messy I didn't want to directly commit in her PR. It's not to be merged to prod
Sorry 🥺
@Dawntraoz This fixes the ordering for bignumbers like sifchain... it's a bit ugly but it works
It's inspired by
orderBalancesByPrice
inuseAccount.ts
, which was not convenient and easy to re-use.Please refactor how you'd like, I at least wanted to give a hint in the right direction since it was tricky to reproduce