EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
12 stars 2 forks source link

Dex Agg: Graceful degradation issue for swap module #1761

Closed eitjuh closed 2 years ago

eitjuh commented 2 years ago

Refer to thread for latest DoD

Right now, when dexinfo or daggregation endpoints are returning 503 errors (or any other error I assume),

We are showing the swap component as if there are no problems. (See screenshot, all denom's are showing 0, while I clearly have balance) See 🧵 : https://allinbits.slack.com/archives/C02TBMVAJDN/p1651226179042009

~ ~The minimal that we should do is show something like an error message on the swap component: "Couldn't load your balances" Or something like that.~ ~

image

sschiessl-bcp commented 2 years ago

This is a frontend issue. Let me know if there should be specific error messages / codes

akc2267 commented 2 years ago

hopefully we can use the same "swap unavailable" message for both this and #1708

peterlewispeterlewis commented 2 years ago

@eitjuh is this accounted for here?

josietyleung commented 2 years ago

As discussed with @pranaybaldev, above issue are two scenarios because dexinfo and daggregation endpoints don't store balances. Let's keep this issue to handle 503 = disable swap widget. Opend a new tix for balance showing up as 0 https://github.com/EmerisHQ/demeris/issues/1811

josietyleung commented 2 years ago

As discussed with @pranaybaldev, we are unsure when will this occur again and how long will this last. Existing handling of either endpoint returning 503 is disabled CTA + text 'Swap Unavailable' for all routes. States listed here.

We also have a swap widget disabled feature flag in place already, let's re-use that for major downtime. As the original swap widget disabled feature flag was built for gravity dex migration, let's update the text + link a bit to make them more relevant

Swap is temporarily unavailable The swap function is currently undergoing maintenance and will be back soon Contact Emeris Support

pranaybaldev commented 2 years ago

Thanks, @josietyleung!