EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
11 stars 2 forks source link

feat: alert and reload on dynamically imported module #1802

Closed fl-y closed 2 years ago

fl-y commented 2 years ago

UNTESTED - could not replicate on local machine

Description

Fixes: #1715

Feature flags

?VITE_FEATURE_SENTRY=1

Testing

Despite @Dawntraoz showcasing how to recreate the issue locally, I could not for the life of me 😞


Reviews (Optional)

Would appreciate some 👀 @Dawntraoz since you know how to replicate locally 🫂

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 1ef3539):

https://emeris-app--pr1802-fix-1715-failed-dyn-m7vv4jhr.web.app

(expires Tue, 14 Jun 2022 07:18:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

faboweb commented 2 years ago

do not clean on build (prod) and then switch route?

Dawntraoz commented 2 years ago

On my way, for testing I just use the command npm run build:production -- --watch, and then:

(If you're in the Pools page when refreshing the build, and comeback to the Portfolio for clicking the detail asset view is easier to see the error)

Dawntraoz commented 2 years ago

For me, the error still appearing :(

faboweb commented 2 years ago

What is the path forward here?

fl-y commented 2 years ago

What is the path forward here?

IIRC @eitjuh tried to fix this using firebase settings via @luciorubeens 's idea but it turned out to be a blank. Back to square one with this idea being controversial due to reasons discussed in multiple threads

fl-y commented 2 years ago

For me, the error still appearing :(

~@Dawntraoz did you turn on Sentry?~ VITE_FEATURE_SENTRY=1

Actually never mind just verified that this doesn't fix it. Will find another way

Dawntraoz commented 2 years ago

@pranaybaldev can we say now that the non version files are working as expected?

Dawntraoz commented 2 years ago

Not needed anymore after Pranay's solution