EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
11 stars 2 forks source link

Wallet switching causes you to see the other wallets balance #1822

Open eitjuh opened 2 years ago

eitjuh commented 2 years ago

See https://allinbits.slack.com/archives/C02AXJ0K9F1/p1652459599620349

clockworkgr commented 2 years ago

can someone who can reproduce it check the vuex state in vue dev tools?

when signing in with a different account/connecting a wallet it should dispatch SIGN_OUT which

Dawntraoz commented 2 years ago

can someone who can reproduce it check the vuex state in vue dev tools?

when signing in with a different account/connecting a wallet it should dispatch SIGN_OUT which

  • removes all previous account subscriptions
  • waits for any existing requests to complete
  • deletes account related data from the store

Just checking that the issue is different if we check the portfolio vs the asset detail page. The SIGN_OUT is being called as I can see the call in Vue Devtools, but something is not being refreshed in the view 🤔

This video shows how it's not working properly when you are navigating in the app from Portfolio > Assets detail page, but it's working if you refresh the page and then start connecting/disconnecting the wallet.

https://user-images.githubusercontent.com/36744484/173319978-3addcb94-5413-4b78-b531-2cd33932df38.mov

@eitjuh maybe will be nice to list all the pages that are having issues and which ones not, so it's easy to find what is misused or not defined properly.