search

EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
11 stars 2 forks source link

fix: update disabled swap component #1824

Closed pranaybaldev closed 2 years ago

pranaybaldev commented 2 years ago

Description

https://github.com/EmerisHQ/demeris/issues/1761#issuecomment-1127542000

Fixes: #1761

Feature flags

VITE_FEATURE_SWAP_WIDGET_DISABLED=1

Testing

Use the flag and ensure that disabled swap component is according to ^^ specifications

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 9c21a7f):

https://emeris-app--pr1824-fix-1761-disabled-sw-smucsuhj.web.app

(expires Tue, 24 May 2022 04:40:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

pranaybaldev commented 2 years ago

Thanks, Mihail.

  1. e2e test - would be addressed in #1809
  2. @josietyleung can answer better.
josietyleung commented 2 years ago

Thanks, Mihail.

  1. e2e test - would be addressed in Create tests for swap component for different states #1809
  2. @josietyleung can answer better.

Oh yes going to Contact makes more sense. Thanks for flagging this @mihailmarcu

josietyleung commented 2 years ago

LGTM - however - I think it's still important to fix this in a different way as well: If some backend error is happening, let's make sure we are not showing infinite loading screens

@eitjuh Infinite loading won't happen, existing logic is if either dexinfo or daggregation returns 404/503, the swap button CTA is disabled with text reading 'swap unavailable'. The disable swap component feature flag is for major downtime