EmerisHQ / demeris

Emeris web app
https://app.emeris.com/
Apache License 2.0
11 stars 2 forks source link

build: switch npm to yarn and resolve vulnerabilities #1827

Open eitjuh opened 2 years ago

eitjuh commented 2 years ago

Hi folks 👋

We have discussed before whether to switch from NPM to Yarn, and we ended up not switching, because NPM was generally easier to debug.

Hereby I still make the suggestion to switch, because:

The following actually resolves the axios dependency. We could directly ask ignite frontend team to update starport/vuex to update dependency @confio/relayer . That would fix it in a better way, but this is a temporary fix:

  "resolutions": {
    "**/@starport/vuex/@confio/relayer/axios": "0.21.2"
  },
github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit ee6979b):

https://emeris-app--pr1827-build-move-npm-to-ya-r5ludcud.web.app

(expires Mon, 13 Jun 2022 10:37:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Dawntraoz commented 2 years ago

Nice idea! Code wise LGTM 💃🏼 Let's see what others say 💜

pranaybaldev commented 2 years ago

Not in support of the switch but don't feel too strongly about it (It'll be fine if we do). Can't we just use overrides?

'overrides' is only available in version 8.x.

faboweb commented 2 years ago

overrides in my experience don't work that well @pranaybaldev. Do you have good experiences with them?

fl-y commented 2 years ago

I also don't feel strongly about switching, however I remember @clockworkgr expressing that using npm made debugging easier. I'll be more comfortable with the PR with Alex's blessing