Closed eitjuh closed 2 years ago
Visit the preview URL for this PR (updated for commit bc98d1f):
https://emeris-app--pr1835-fix-move-to-script-s-3unx8yif.web.app
(expires Mon, 13 Jun 2022 07:34:04 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Note: I'm actually quite certain that this MUST break SOMETHING, SOMEWHERE. It's just a matter of what exactly. However, for the benefit of cleaning up our codebase, and trying to gain some speed towards improving our product, I'd still want to push this forward (and if things break, the tests or PR should have covered it anyway)
Update: Actually now it's not just the homepage - everything should be resolved when you run
npm run build
fix: move-to-script-setup-and-fix-all-eslint-errors
Reason for doing:
Changes like:
Testing:
Main testing that I have done:
Scope:
npm run dev
, all eslint warnings are gone - the other pages still have plenty, but have to start somewhere...