Closed faboweb closed 2 years ago
github-actions[bot]
commented
2 years ago Visit the preview URL for this PR (updated for commit f696fc4):
https://emeris-app--pr1837-chore-replace-iscypr-cvlvidke.web.app
(expires Tue, 14 Jun 2022 01:12:53 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
fl-y
commented
2 years ago clicking on agree after trying to connect a wallet doesn't actually connect the wallet as it relys on the old sign in flow. Are you aware? Am I missing sth?
Just saw this but I'm afraid I don't really understand the question - I couldn't really find where the user has to click on agree, can you elaborate?
faboweb
commented
2 years ago u need to agree the terms of service. if it doesn’t pop up for u, maybe clean the browser storage for the page. it will not pop up again after agrred to once
Joon @.***> schrieb am Mo. 6. Juni 2022 um 19:02:
clicking on agree after trying to connect a wallet doesn't actually connect the wallet as it relys on the old sign in flow. Are you aware? Am I missing sth?
Just saw this but I'm afraid I don't really understand the question - I couldn't really find where the user has to click on agree, can you elaborate?
— Reply to this email directly, view it on GitHub https://github.com/EmerisHQ/demeris/pull/1837#issuecomment-1147324772, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMY5WN4AAEZM2DDDI4SZHLVNXLELANCNFSM5X3G3JQA . You are receiving this because you authored the thread.Message ID: @.***>
-- Greets Fabo
Description
Currently we are handling e2e test account setup in code. We should not. It makes the code bad to read and avoids real testing. Instead I propose here a mock of Keplr added to the page via playwright.
Test with:
npx env-cmd npm run test:e2e -- --workers=2 -g "time to unstake is a number"Tests need
VITE_EMERIS_MNEMONICmakes it kind of hard to test locally.@fl-y clicking on agree after trying to connect a wallet doesn't actually connect the wallet as it relys on the old sign in flow. Are you aware? Am I missing sth?