fix: add bigger exponential margin to bigNumber to avoid +20 syntax - Githubissues

EmerisHQ / demeris

Emeris web app

https://app.emeris.com/

Apache License 2.0

12 stars 2 forks source link

fix: add bigger exponential margin to bigNumber to avoid +20 syntax #1843

Closed Dawntraoz closed 2 years ago

Dawntraoz commented 2 years ago

Description

There was a problem with the CoinList not showing any coins because of a JS failure due to a wrong coin string.

Bug reported by Mussa on Slack: https://allinbits.slack.com/archives/C02AXJ0K9F1/p1654590084181009
Sentry trace of the error: https://sentry.io/organizations/ignite-o4/issues/3330529081/?project=6232236&referrer=slack

The problem was related to the BigNumber only allowing max 20 number before being exponential, setting up 24 as the maximum fixes.

But will be nice to have a proper way in regex to match with a string container exponential as +20 or -20 (To be discussed with the team)

Testing

In your .env.local file, add this variable (that includes the Mussa public key example): VITE_EMERIS_DEMO_PUBKEY=A3BwTNpmu62RMVBCp3oCqw36Cpa9bigfEhj6zDz9VfHP
Now run npm run dev, and in the localhost:8080 click on Stake asset.
Check the list of coins being shown.

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 0e5adab):

https://emeris-app--pr1843-fix-coin-list-issue-htblzz68.web.app

_{(expires Tue, 14 Jun 2022 21:15:56 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}